feat(writer): NULL_COUNT zone-maps for dict-encoded columns#127
Merged
Conversation
Global-dict columns live in a separate write path (dictColRefs) that flushZoneMaps did not touch, so they carried no zone-map. Rust zone-maps dict columns too (vortex.stats wrapping vortex.dict), so capture per-chunk null counts in DictColRef and emit a NULL_COUNT-only zone-map wrapping the dict layout. Global-dict columns are dense (non-nullable) so counts are 0 today, but the plumbing is correct for future nullable-dict support. Closes the main null_count gap: every column type, dict or not, now carries a zone-map. New code fully covered; full suites + Rust interop green. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global-dict columns live in a separate write path (dictColRefs) that
flushZoneMaps did not touch, so they carried no zone-map. Rust zone-maps
dict columns too (vortex.stats wrapping vortex.dict), so capture per-chunk
null counts in DictColRef and emit a NULL_COUNT-only zone-map wrapping the
dict layout. Global-dict columns are dense (non-nullable) so counts are 0
today, but the plumbing is correct for future nullable-dict support.
Closes the main null_count gap: every column type, dict or not, now
carries a zone-map. New code fully covered; full suites + Rust interop green.
Co-Authored-By: Claude Opus 4.8 [email protected]