Skip to content

[Snyk] Fix for 9 vulnerabilities #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dextrorsal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 9 vulnerabilities #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
aiodns==3.0.0
aiohttp==3.8.3
aiohttp==3.13.3
aiosignal==1.3.1
anchorpy==0.17.1
anchorpy-core==0.1.2
Expand Down Expand Up @@ -79,7 +79,7 @@ types-cachetools==4.2.10
types-requests==2.28.11.5
types-urllib3==1.26.25.4
typing_extensions==4.4.0
urllib3==1.26.13
urllib3==2.6.3

@sentry sentry Bot Jan 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pinned requests version 2.28.1 is incompatible with the upgraded urllib3 version 2.6.3, which will cause runtime errors when making HTTP requests.
Severity: CRITICAL

🔍 Detailed Analysis

The requirements.txt file pins requests==2.28.1 and urllib3==2.6.3. However, requests version 2.28.1 has a strict dependency requirement for urllib3<2. This version incompatibility will cause a runtime failure when requests.get() is called in initialize_vault.py and configure_vault.py. These scripts will fail to fetch the necessary vault IDL from GitHub, breaking their core functionality.

💡 Suggested Fix

To resolve the incompatibility, either downgrade urllib3 to a version compatible with requests==2.28.1 (e.g., urllib3<2), or upgrade requests to a version that supports urllib3>=2.0 (e.g., requests>=2.31.0). Ensure all dependencies are compatible after the change.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: requirements.txt#L82

Potential issue: The `requirements.txt` file pins `requests==2.28.1` and
`urllib3==2.6.3`. However, `requests` version `2.28.1` has a strict dependency
requirement for `urllib3<2`. This version incompatibility will cause a runtime failure
when `requests.get()` is called in `initialize_vault.py` and `configure_vault.py`. These
scripts will fail to fetch the necessary vault IDL from GitHub, breaking their core
functionality.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8531868

watchdog==2.2.0
websockets==10.4
wrapt==1.16.0
Expand Down