Skip to content

#756: Add tests for CustomToolRepository using WireMock#2031

Open
vivu001 wants to merge 3 commits into
devonfw:mainfrom
vivu001:feature/756-implement-custom-tool-repository-test
Open

#756: Add tests for CustomToolRepository using WireMock#2031
vivu001 wants to merge 3 commits into
devonfw:mainfrom
vivu001:feature/756-implement-custom-tool-repository-test

Conversation

@vivu001

@vivu001 vivu001 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #756

Implemented changes:

  • Improve test coverage by adding tests for CustomToolRepository

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jun 16, 2026
@vivu001 vivu001 added enhancement New feature or request test related to testing and QA custom ide-custom-tools.json and related features labels Jun 16, 2026
@coveralls

coveralls commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27673466541

Coverage increased (+0.4%) to 71.694%

Details

  • Coverage increased (+0.4%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 2 90.03%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 16222
Covered Lines: 12120
Line Coverage: 74.71%
Relevant Branches: 7250
Covered Branches: 4708
Branch Coverage: 64.94%
Branches in Coverage %: Yes
Coverage Strength: 3.16 hits per line

💛 - Coveralls

@vivu001 vivu001 marked this pull request as ready for review June 17, 2026 07:46
@Caylipp Caylipp self-assigned this Jun 17, 2026
@Caylipp Caylipp moved this from 🆕 New to Team Review in IDEasy board Jun 17, 2026
@Caylipp

Caylipp commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

The test suite looks well structured and comprehensive. Good job 👍
I tested with mvn clean test and all tests run successfully!

The Arrange/Act/Assert pattern is used consistently and the scenarios are clearly separated.
Overall, very clean and solid test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

custom ide-custom-tools.json and related features enhancement New feature or request test related to testing and QA

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Implement CustomToolRepositoryTest

3 participants