Skip to content

#822: added length limit to cwd path in order to make the path more r…#2024

Open
marceltchanga9 wants to merge 3 commits into
devonfw:mainfrom
marceltchanga9:feature/822_handle_cwd_paths_in_shell_prompt
Open

#822: added length limit to cwd path in order to make the path more r…#2024
marceltchanga9 wants to merge 3 commits into
devonfw:mainfrom
marceltchanga9:feature/822_handle_cwd_paths_in_shell_prompt

Conversation

@marceltchanga9

@marceltchanga9 marceltchanga9 commented Jun 15, 2026

Copy link
Copy Markdown

This PR fixes 822

Implemented changes:

Added line separator when the cwd path is longer than 80

Testing instructions

  1. Create in the project folder a sub-folder with a name having more than 80 characters ( eg : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaatestlength)
  2. Run the CLI Application with argument --shell
  3. Navigate to the folder you created in the command line ( cd ...)
  4. Check that the line breaks and "$ide" is at the beginning of a new line
  5. To make sure that the test works, you can also test it with folder's name shorter or longer than 80
  6. Delete the folder(s) you created

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls

coveralls commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27544342972

Warning

No base build found for commit dd49f20 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 71.071%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15833
Covered Lines: 11743
Line Coverage: 74.17%
Relevant Branches: 7068
Covered Branches: 4533
Branch Coverage: 64.13%
Branches in Coverage %: Yes
Coverage Strength: 3.14 hits per line

💛 - Coveralls

@marceltchanga9 marceltchanga9 moved this from 🆕 New to Team Review in IDEasy board Jun 15, 2026
@marceltchanga9 marceltchanga9 marked this pull request as ready for review June 15, 2026 12:04
@oanding-blrng

Copy link
Copy Markdown
Contributor

I'm only able to recreate the original problem mentioned in #822. It is not clear to me, how to properly test the correct behavior implemented in this ticket/pull request.

@marceltchanga9 Please provide clearer steps for testing and add appropriate labels, which match the labels of the original ticket.

@marceltchanga9

Copy link
Copy Markdown
Author

I'm only able to recreate the original problem mentioned in #822. It is not clear to me, how to properly test the correct behavior implemented in this ticket/pull request.

@marceltchanga9 Please provide clearer steps for testing and add appropriate labels, which match the labels of the original ticket.

@oanding-blrng I updated the test steps. They should be now more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

4 participants