#1937: link content from settings into workspace(s)#1983
Open
tineff96 wants to merge 20 commits into
Open
Conversation
…(initial implementation)
Collaborator
Coverage Report for CI Build 27688586400Coverage increased (+0.007%) to 71.292%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions33 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
Contributor
Author
|
Note: |
f7ec9f6 to
cb85dbe
Compare
hohwille
reviewed
Jun 3, 2026
hohwille
left a comment
Member
There was a problem hiding this comment.
@tineff96 thanks for your PR. You found the right spots and your changes to config and properties seem perfect. 👍
I added some review comment to better reuse existing code avoiding redundancies.
Since you add a new feature, could you also add a JUnit test method covering it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1937
Implemented virtual settings repository feature. A
settings.propertieswithoutgit_urlnow indicates a virtual repository that reuses the already cloned$IDE_HOME/settingsfolder. Sub-folders fromsettingscan be linked intoworkspaces via the
linkproperty, e.g.:This avoids the need to create and maintain separate git repositories for
shared configuration content.
Implemented changes:
isVirtualSettingsRepository()toRepositoryConfig— returnstruewhen
id=settingsand nogit_urlis setcreateSettingsRepositoryLinks()toRepositoryCommandlet— iteratesover all configured workspaces and creates symlinks
linkTargetExists()toRepositoryCommandlet— validates link targetexists before creating symlink, logs warning and skips if not
git_urlvalidation inRepositoryPropertiesfor virtual settingsrepositories
testSetupVirtualSettingsRepository()Testing instructions
Automated test
A JUnit test was added for this feature and can be executed with:
The test verifies that a virtual settings repository without
git_urlcan create configured links from the settings directory into the workspace.Manual test
Create a subfolder in
$IDE_HOME/settings/, e.g.ai/, with any file inside.Create
$IDE_HOME/settings/repositories/settings.propertieswith content:Note: no
git_urlproperty is required. This is intentional for a virtual settings repository.Verify that
.githubis a link pointing to$IDE_HOME/settings/ai/in every workspace under$IDE_HOME/workspaces/.Run
ide repository setupa second time. It should complete without errors.Change the link target to a non-existing folder, e.g.:
Run again. It should log that the target does not exist and skip the link without crashing.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal