#1784 implement java fx based progress bars for the GUI#1935
Conversation
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
- Added testing class for modals
- Added logging to IdeGuiStateManager. - Added functionality, that selecting a different project now switches the IdeContext to the new project.
…t-for-gui' into devonfw#1785-implement-modals-in-idecontext
- Added functionality, that selecting a different project now switches the IdeContext to the new project.
…plementation' into devonfw#1802-state-management-implementation
…r other ui feature branches
- Added Task overview window - added ListView that allows to manage concurrent tasks
…g progress -> better performance and higher reliability
- added DI for IdeGuiStateManager.switchContext
…reading the list of workspaces/projects instead of reading those from the UI
…nager, when switchContext(Path rootDirectory, ...) is called.
- taskids are now strings, based on UUID.randomUUID() - The TaskOverviewWindow is now displayed directly above the layout node that opens it - progress units are now shown in TaskOverviewWindow
This reverts commit 6f92d93.
…plementation' into devonfw#1802-state-management-implementation
…tateManager is now set when calling getInstance(), allowing us to provide a getInstance() method with a DI parameter
… getInstance()) (see previous commit)
…nfw#1784-Implement-JavaFX-based-progress-bars-for-the-GUI # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/gui/Gui.java
Coverage Report for CI Build 27630490958Coverage increased (+0.05%) to 71.335%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions71 previously-covered lines in 5 files lost coverage.
Coverage Stats💛 - Coveralls |
|
Merge #1802 first, then update this & merge (after review) |
…-bars-for-the-GUI # Conflicts: # gui/src/main/java/com/devonfw/ide/gui/App.java # gui/src/main/java/com/devonfw/ide/gui/MainController.java # gui/src/main/java/com/devonfw/ide/gui/context/IdeGuiContext.java # gui/src/main/resources/com/devonfw/ide/gui/main-view.fxml # gui/src/test/java/com/devonfw/ide/gui/AppBaseTest.java
…TaskManager; updated some Javadocs, removed redundant property tags in main-view.fxml, fixed typos
|
Great job, the progress bars are a really nice addition. They give the user clear feedback instead of just waiting without knowing what is happening 👍I left a few notices. |
|
I am not sure if this only happens on my side, but the progress bars were only shown when I started the GUI via |
Oh ok! Good to know! Did you see something like a status text? Maybe let's take this out of the release then. |
|
I also figured that it seems like sometimes things that work via AppLauncher don't work when launched via the Commandlet... |
|
Small suggestion: I noticed that the task window stays open even after multiple tasks are finished. Once the IDE(s) are downloaded, extracted, and launched successfully, it would be nice if the task/progress window closed automatically. |
This PR fixes #1784
This PR depends on #1802
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalTesting instructions
ide gui