This repository was archived by the owner on Aug 11, 2026. It is now read-only.
Potential fix for code scanning alert no. 83: Client-side URL redirect - #1133
Draft
farabi-deriv wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 83: Client-side URL redirect#1133farabi-deriv wants to merge 1 commit into
farabi-deriv wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
farabi-deriv
had a problem deploying
to
Development
June 27, 2025 06:36 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Check warning
Code scanning / CodeQL
Client-side URL redirect
Check warning
Code scanning / CodeQL
Client-side URL redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/deriv-com/smarttrader/security/code-scanning/83
To fix the issue, we need to ensure that the
redirect_urlis validated against a whitelist of trusted domains or paths before redirection. This can be achieved by maintaining a list of authorized URLs on the server or in the client code and checking theredirect_urlagainst this list. If theredirect_urlis not in the whitelist, the code should default to a safe URL.Steps to fix:
redirect_urlagainst this whitelist before using it inwindow.location.replace.redirect_urlis not in the whitelist, set it to a default safe URL.Suggested fixes powered by Copilot Autofix. Review carefully before merging.