refactor: remove dead notebook.py shadowed by notebook/ package#59
Merged
Conversation
Python's import system resolves deployml.notebook to the notebook/ package, never the same-named notebook.py module, so the module was unreachable. Its exports (deploy, load, DeploymentStack, ServiceURLs) are already provided identically by notebook/__init__.py, and the CLI already imports deployml.notebook.docker (a package-only submodule), proving the package is what's in use.
jivanb7
added a commit
that referenced
this pull request
Jun 1, 2026
…and dead notebook.py removal (PR #59), keep the Windows compat and run_tool work # Conflicts: # src/deployml/cli/cli.py # src/deployml/enum/cloud_provider.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's import system resolves deployml.notebook to the notebook/ package, never the same-named
notebook.py module, so the module was unreachable. Its exports (deploy, load, DeploymentStack,
ServiceURLs) are already provided identically by notebook/init.py, and the CLI already imports
deployml.notebook.docker (a package-only submodule), proving the package is what's in use.