Skip to content

fix: QdrantDocumentStore removing duplicated tests already covered by haystack Mixin tests + fixing dedup + adding missing Async test - #3785

Open
davidsbatista wants to merge 5 commits into
mainfrom
test/consolidate-metadata-unique-values-qdrant
Open

fix: QdrantDocumentStore removing duplicated tests already covered by haystack Mixin tests + fixing dedup + adding missing Async test#3785
davidsbatista wants to merge 5 commits into
mainfrom
test/consolidate-metadata-unique-values-qdrant

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed changes

  • Removed duplicataed tests, now relying on Mixng

  • Python treats 1 == True == 1.0, so the plain set() used to dedupe unique metadata values collapsed them into one when a field held mixed types across documents. Now dedupes by (type(value), value) instead of value alone, so values of different types stay distinct.

  • The sync test class already overrides test_get_metadata_field_unique_values_pagination with an order-tolerant check (page size / total count / no overlap), since Qdrant's scroll() doesn't guarantee value order. The async class was missing the equivalent override

Checklist

@github-actions github-actions Bot added integration:qdrant type:documentation Improvements or additions to documentation labels Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Coverage report (qdrant)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/qdrant/src/haystack_integrations/document_stores/qdrant
  document_store.py 754
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista davidsbatista changed the title tests: QdrantDocumentStore removing duplicated tests already covered by haystack Mixin tests fix: QdrantDocumentStore removing duplicated tests already covered by haystack Mixin tests + fixing dedup + adding missing Async test Aug 25, 2026
@davidsbatista
davidsbatista marked this pull request as ready for review August 25, 2026 17:08
@davidsbatista
davidsbatista requested a review from a team as a code owner August 25, 2026 17:08
@davidsbatista
davidsbatista requested review from julian-risch and removed request for a team August 25, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:qdrant type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant