fix: narrow bare except to ImportError in constant module init#69
Open
fix2015 wants to merge 1 commit into
Open
fix: narrow bare except to ImportError in constant module init#69fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bare
except:clause indeepspec/utils/constant/__init__.pycatches all exceptions, includingKeyboardInterrupt,SystemExit, andSyntaxError. This means that ifinternal.pycontains a real bug (e.g., a syntax error or an unrelated runtime error), it will be silently swallowed and the code will fall back to the public module without any indication of a problem.This change narrows the exception handler to only catch
ImportErrorandModuleNotFoundError, which are the expected exceptions whenhfaiis not installed. Any other exceptions will now properly propagate, making debugging significantly easier.Changes
deepspec/utils/constant/__init__.py: Replace bareexcept:withexcept (ImportError, ModuleNotFoundError):