Skip to content

Avoid duplicate final checkpoint save#66

Open
morluto wants to merge 1 commit into
deepseek-ai:mainfrom
morluto:fix-duplicate-final-checkpoint
Open

Avoid duplicate final checkpoint save#66
morluto wants to merge 1 commit into
deepseek-ai:mainfrom
morluto:fix-duplicate-final-checkpoint

Conversation

@morluto

@morluto morluto commented Jul 11, 2026

Copy link
Copy Markdown

What

BaseTrainer.train() saves a checkpoint at every configured checkpoint interval, then unconditionally saves again after the training loop.

When the final training step falls on a checkpoint interval, this writes the same step_<N> checkpoint twice and submits automatic evaluation twice.

Change

Only perform the post-loop save when the final step was not already checkpointed.

Runs that finish between checkpoint intervals still save their final checkpoint as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant