Fix IndexError for positional-only default arguments#3
Open
theweaklink wants to merge 1 commit into
Open
Conversation
PyCG's _get_fun_defaults only indexed node.args.args, but PEP 570 defaults apply to the combined posonlyargs + args list. Functions such as `def eye(n_rows, n_cols=None, /)` caused IndexError during static analysis when third-party modules were scanned. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_fun_defaultsinPreProcessorto map default values usingposonlyargs + argsinstead of onlyargs, per PEP 570.def eye(n_rows, n_cols=None, /)) and regular positional defaults.This resolves
IndexError: list index out of rangeinonecode-build/onecode-extractwhen PyCG statically analyzes third-party code containing positional-only parameters with defaults (common in recent scipy/numpy/sklearn sources).Context
The PyPI package is published as
onecode-pycg, sourced from this repository'sonecodebranch.The crash was observed on Windows when a
.venvlives inside the OneCode project directory: PyCG then treatssite-packagesmodules as local project code and parses them. One such function is scipy'seye(n_rows, n_cols=None, /), which triggers the bug in_get_fun_defaults.Test plan
python3 -m unittest discover -s pycg/tests -p "preprocessor_test.py"make test(requiresmockpackage for existing tests)onecode-extracton a OneCode project with in-project.venvon WindowsMade with Cursor