Skip to content

[cms] Invoice batch and token inventory route - #1176

Open
thi4go wants to merge 8 commits into
decred:masterfrom
thi4go:invoice-batch
Open

[cms] Invoice batch and token inventory route#1176
thi4go wants to merge 8 commits into
decred:masterfrom
thi4go:invoice-batch

Conversation

@thi4go

@thi4go thi4go commented Apr 28, 2020

Copy link
Copy Markdown
Member

This diff adds two calls, one for invoices token inventory, and one for batched invoices. These calls will increase loading time performance in cmsgui, and provide a better lazy loading and pagination solution.

closes #1036

@alexlyp

alexlyp commented Apr 28, 2020

Copy link
Copy Markdown
Member

Looks like you added a piwww built bin into the PR, please do remove. Thanks!

@thi4go

thi4go commented Apr 28, 2020

Copy link
Copy Markdown
Member Author

My bad mate @alexlyp removed it!

@alexlyp alexlyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, good stuff.

@alexlyp

alexlyp commented Aug 5, 2020

Copy link
Copy Markdown
Member

Please rebase this again and make sure to resolve the issue with a dual InvoiceListPageSize if it appears like it did for me on rebase.

Also can you rename cmd/cmswww/tokeninventory.go to invoicetokeninventory.go to avoid confusion in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cms: create batched calls for invoices

2 participants