fix(google-calendar-sa): deduplicate events across impersonated emails#474
Merged
Conversation
Events with minutesUntilStart < 0 were not filtered, causing past meetings to trigger notifications on first scheduler tick. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The same meeting appears in multiple impersonated emails. Including the email in the dedup key caused duplicate notifications across scheduler ticks. Now the key is connectionId:eventId:startTime. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same meeting visible to multiple impersonated emails caused duplicate notifications. Dedup key now excludes email.
Summary by cubic
Prevents duplicate notifications in
google-calendar-sawhen the same meeting appears under multiple impersonated emails, and stops notifying for meetings that already started.${connectionId}:${eventId}:${startTime}(removed email) to avoid cross-email duplicates.Written for commit d0c06ca. Summary will update on new commits.