fix(core): prevent empty tsc labels on nodes#2351
Open
diafour wants to merge 1 commit into
Open
Conversation
diafour
commented
May 15, 2026
| edk2: stable202411 | ||
| core: | ||
| 3p-kubevirt: v1.6.2-v12n.30 | ||
| 3p-kubevirt: dvp/update-kube-api-rewriter-fix-empty-label-values |
Member
Author
There was a problem hiding this comment.
Do not forget to change after tagging 3p-kubevirt!
- Update kube-api-rewriter to v0.2.1 - Update 3p-kubevirt to v1.6.2-v12n.31 with updated kube-api-rewriter See: - deckhouse/kube-api-rewriter#7 - deckhouse/3p-kubevirt#110 Signed-off-by: Ivan Mikheykin <[email protected]>
ea99b3a to
8330afb
Compare
danilrwx
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See:
Why do we need it, and what problem does it solve?
nullvalue for label in the strategic patch means "delete property", but kube-api-rewriter change those nulls to empty strings, so Nodes was labeled with unneeded empty tsc labels.What is the expected result?
Before:
Stale labels are keeped on node:
After:
Rewrite now keep nulls for strategic patch, no stale labels on nodes:
Checklist
Changelog entries