add rpc validation for evm - #50
Open
mncdg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rpc validation checks that we have the same submissionId in responses from different rpc. If Debridge Node couldnt detect on configured rpc the same submissionId, the submission will not be signed.
How to setup?
You should add
rpcConfirmationto chain_config.jsonExample:
[ { "chainId": 137, "providers": [ { "provider": "https://polygon-rpc.com/", }, ], "name": "MATIC", ... "rpcConfirmation": 2 } ]For marking rpc as required you should add
"requireConfirmation": truein provider. It means that if validator detect required count rpc confirmation submission cant be confirmed without required rpc .Example:
[ { "chainId": 137, "providers": [ { "provider": "https://polygon-rpc.com/", "requireConfirmation": true }, { "provider": "https://rpc.ankr.com/polygon/", } ], "name": "MATIC", ... "rpcConfirmation": 2 } ]