Skip to content

[DEPLOY] 배포#467

Merged
i-meant-to-be merged 1 commit into
mainfrom
develop
Jul 19, 2026
Merged

[DEPLOY] 배포#467
i-meant-to-be merged 1 commit into
mainfrom
develop

Conversation

@i-meant-to-be

Copy link
Copy Markdown
Contributor
  • chore: 에셋 추가

  • chore: 국제화 항목 추가

  • chore: 패치노트 갱신

  • refactor: 패치노트 모달 국제화 적용 및 일부 구조 개선

  • refactor: 국제화 적용에 따른 ModalWrapper 수정

  • feat: 닫기 버튼 추가

* chore: 에셋 추가

* chore: 국제화 항목 추가

* chore: 패치노트 갱신

* refactor: 패치노트 모달 국제화 적용 및 일부 구조 개선

* refactor: 국제화 적용에 따른 ModalWrapper 수정

* feat: 닫기 버튼 추가
@i-meant-to-be i-meant-to-be self-assigned this Jul 19, 2026
@i-meant-to-be i-meant-to-be added the deploy develop에서 main으로의 배포 label Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 047b9e7d-7cf2-419a-8c4b-5ae6ac9c00b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@i-meant-to-be
i-meant-to-be merged commit c07bcd9 into main Jul 19, 2026
2 checks passed
@i-meant-to-be
i-meant-to-be deployed to DEPLOY_PROD July 19, 2026 08:43 — with GitHub Actions Active

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces internationalization (i18n) support to the UpdateModal component, allowing titles, descriptions, and images to be rendered in either Korean or English based on the user's language settings. It also adds comprehensive test suites for both UpdateModal and UpdateModalWrapper to verify correct localization and modal dismissal behaviors. The feedback highlights a potential TypeScript type error in UpdateModal.tsx where primaryLang could be undefined under strict null checks, and suggests a safer conditional check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +27 to +29
const currentLang = i18n.resolvedLanguage ?? i18n.language;
const primaryLang = currentLang?.split(/[-_]/)[0];
const lang = isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

i18n의 언어 설정이 정의되지 않은 경우(currentLangundefined인 경우), primaryLang 역시 undefined가 됩니다. 이 경우 isSupportedLang(primaryLang)을 호출할 때 TypeScript의 strict 모드(strictNullChecks)에서 타입 에러가 발생할 수 있습니다. primaryLang이 존재할 때만 isSupportedLang을 호출하도록 안전장치를 추가하는 것이 좋습니다.

Suggested change
const currentLang = i18n.resolvedLanguage ?? i18n.language;
const primaryLang = currentLang?.split(/[-_]/)[0];
const lang = isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG;
const currentLang = i18n.resolvedLanguage ?? i18n.language;
const primaryLang = currentLang?.split(/[-_]/)[0];
const lang = primaryLang && isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy develop에서 main으로의 배포

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant