[DEPLOY] 배포#467
Conversation
* chore: 에셋 추가 * chore: 국제화 항목 추가 * chore: 패치노트 갱신 * refactor: 패치노트 모달 국제화 적용 및 일부 구조 개선 * refactor: 국제화 적용에 따른 ModalWrapper 수정 * feat: 닫기 버튼 추가
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces internationalization (i18n) support to the UpdateModal component, allowing titles, descriptions, and images to be rendered in either Korean or English based on the user's language settings. It also adds comprehensive test suites for both UpdateModal and UpdateModalWrapper to verify correct localization and modal dismissal behaviors. The feedback highlights a potential TypeScript type error in UpdateModal.tsx where primaryLang could be undefined under strict null checks, and suggests a safer conditional check.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const currentLang = i18n.resolvedLanguage ?? i18n.language; | ||
| const primaryLang = currentLang?.split(/[-_]/)[0]; | ||
| const lang = isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG; |
There was a problem hiding this comment.
i18n의 언어 설정이 정의되지 않은 경우(currentLang이 undefined인 경우), primaryLang 역시 undefined가 됩니다. 이 경우 isSupportedLang(primaryLang)을 호출할 때 TypeScript의 strict 모드(strictNullChecks)에서 타입 에러가 발생할 수 있습니다. primaryLang이 존재할 때만 isSupportedLang을 호출하도록 안전장치를 추가하는 것이 좋습니다.
| const currentLang = i18n.resolvedLanguage ?? i18n.language; | |
| const primaryLang = currentLang?.split(/[-_]/)[0]; | |
| const lang = isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG; | |
| const currentLang = i18n.resolvedLanguage ?? i18n.language; | |
| const primaryLang = currentLang?.split(/[-_]/)[0]; | |
| const lang = primaryLang && isSupportedLang(primaryLang) ? primaryLang : DEFAULT_LANG; |
chore: 에셋 추가
chore: 국제화 항목 추가
chore: 패치노트 갱신
refactor: 패치노트 모달 국제화 적용 및 일부 구조 개선
refactor: 국제화 적용에 따른 ModalWrapper 수정
feat: 닫기 버튼 추가