Find improvements#43
Merged
Merged
Conversation
… .content files.
…into find-improvements # Conflicts: # README.md # shell/find.go
Author
|
@ddvk Do you perhaps have any status updates on this? I'm maintaining my own fork with these changes implemented and they work fine in production settings. If you have any qualms about code quality, tests, documentation or anything else, please let me know and I can get get to it. If you think it doesn't fit the rmapi as a project, also understandable, but then say so and close the PR. It's a bit of a shame to just let it sit here imo. Same goes for the other PR: #46. I would like to build further upon them as well. |
Owner
|
it still says there are conflicts, otherwise I would have merged it |
Author
It does? 
I'm getting "No conflicts with base branch", odd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #40, I wanted to resolve the copilot feedback.
On top of that, there was an issue where files that were trashed were included in find results. I've filtered them out. Didn't even know this was a thing!
Don't think it's worth including an option to leave them in.