Skip to content

Fix map's change (issue 105)#106

Open
matiboy wants to merge 6 commits into
dbrattli:mainfrom
matiboy:issue-105
Open

Fix map's change (issue 105)#106
matiboy wants to merge 6 commits into
dbrattli:mainfrom
matiboy:issue-105

Conversation

@matiboy

@matiboy matiboy commented Jan 11, 2023

Copy link
Copy Markdown

Add simple test for change

mat added 2 commits January 11, 2023 07:07
@matiboy

matiboy commented Jan 11, 2023

Copy link
Copy Markdown
Author

Tinkering with this PR and tests made me realize what I think is another issue:

m1 = Map.empty().add('a',1)
m2 = Map.empty().add('a',1).add('b',2)

m1 == m2 # True
m2 == m1 # False

@dbrattli

dbrattli commented Feb 4, 2023

Copy link
Copy Markdown
Owner

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

Comment thread tests/test_map.py
Comment thread tests/test_map.py
@matiboy

matiboy commented Feb 4, 2023

Copy link
Copy Markdown
Author

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

Hi @dbrattli Sure please feel free to copy the test into main/your own branch and close this PR, no issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants