Skip to content

Add explicit no-change annotations and batch stats overhaul#52

Merged
catchambers merged 8 commits into
mainfrom
v0.1.0
May 13, 2026
Merged

Add explicit no-change annotations and batch stats overhaul#52
catchambers merged 8 commits into
mainfrom
v0.1.0

Conversation

@catchambers

@catchambers catchambers commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve synonymous no-change variants with explicit = markers across annotation and AA aggregation.
  • Normalize batch output structure and batch stats reporting, including structured per-stage summaries and final summary metrics.
  • Update batch output paths, docs, and release metadata for the 0.1.0 release prep.
  • Add and update unit/integration coverage for annotation, sequence parsing, AA aggregation, batch normalization, and summary stats.

Testing

  • Added and updated unit tests for annotation, sequence parsing, AA score aggregation, batch normalization, and summary-stat output shape.
  • Added an integration-style batch normalization test to cover batch config loading and output generation.

@catchambers catchambers marked this pull request as ready for review May 13, 2026 20:17
@catchambers catchambers merged commit dbd9bb9 into main May 13, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e59c5d0757

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


def classify_aa_variant(aa_diff, dna_diff=None):
if not aa_diff or aa_diff == '':
if aa_diff == NO_DIFF_MARKER:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Accept legacy blank no-change markers in AA classification

This classifier now treats only '=' as “no amino-acid change”, but older score tables (and callers that still use compare_to_reference with its default) represent no-change as ''. In those inputs, aa_seq_diff == '' now falls through to missense_aa, which can corrupt downstream WT/synonymous-dependent stats and normalization when reprocessing legacy outputs or pre-annotated data.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant