Add explicit no-change annotations and batch stats overhaul#52
Conversation
…comparisons. Remove fallback value and instead raise ValueError for pre-annotated parsing errors. Update related tests.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e59c5d0757
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def classify_aa_variant(aa_diff, dna_diff=None): | ||
| if not aa_diff or aa_diff == '': | ||
| if aa_diff == NO_DIFF_MARKER: |
There was a problem hiding this comment.
Accept legacy blank no-change markers in AA classification
This classifier now treats only '=' as “no amino-acid change”, but older score tables (and callers that still use compare_to_reference with its default) represent no-change as ''. In those inputs, aa_seq_diff == '' now falls through to missense_aa, which can corrupt downstream WT/synonymous-dependent stats and normalization when reprocessing legacy outputs or pre-annotated data.
Useful? React with 👍 / 👎.
Summary
=markers across annotation and AA aggregation.0.1.0release prep.Testing