[CFX-6647] windows smoke tests for exercising dr self completion install#607
Draft
ajalon1 wants to merge 6 commits into
Draft
[CFX-6647] windows smoke tests for exercising dr self completion install#607ajalon1 wants to merge 6 commits into
dr self completion install#607ajalon1 wants to merge 6 commits into
Conversation
Get-DRCompletionProfilePath and Test-DRCompletionProfile were each called from exactly one site. Inline them into Test-DRCompletionInstallWithExecutionPolicy to co-locate the logic with its only consumer. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
Author
|
/approve-smoke-tests |
Contributor
|
🔐 Fork PR smoke tests triggered by @ajalon1 What happens next:
|
Contributor
|
🔐 Fork smoke tests started by maintainer ⏳ Security scans passed. Running smoke tests... Commit: |
Contributor
|
❌ Some smoke tests failed. (Fork PR) ✅ Security Scan: success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Realized that we don't have smoke tests for
dr self completion install, only fordr self completion.CHANGES
Add to Windows smoke tests PS1 two testing scenarios:
dr self completion installwhen execution policy is restricted, as when we have a fresh Windows installdr self completion installwhen execution policy is permissiveDocument some of the methods.
oof, writing PS1 scripts.
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: The
run-smoke-testslabel won't work. A required Smoke Tests check will block merge until a maintainer acts:/approve-smoke-teststo run smoke tests (results will set the check)/skip-smoke-teststo bypass the check without running testsPlease comment requesting a maintainer review if you need smoke tests to run.