Skip to content

fix(sync): reconcile unchanged manifests for drift#23

Merged
vanducng merged 1 commit into
mainfrom
fix/sync-drift-root
May 30, 2026
Merged

fix(sync): reconcile unchanged manifests for drift#23
vanducng merged 1 commit into
mainfrom
fix/sync-drift-root

Conversation

@vanducng

Copy link
Copy Markdown
Contributor

Summary

  • keep gcplane serve reconciling provider state even when the git source hash is unchanged
  • fix teams.update payload shape so team settings actually apply
  • normalize []any and []string slices to avoid noisy grant drift

Tests

  • go test ./...
  • git diff --check

@coderabbitai

coderabbitai Bot commented May 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@vanducng, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 60 minutes. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: edf90077-eda9-4c17-98e4-f2692fc959d9

📥 Commits

Reviewing files that changed from the base of the PR and between b3a43ae and 273ffc3.

📒 Files selected for processing (7)
  • internal/controller/controller.go
  • internal/controller/controller_test.go
  • internal/provider/goclaw/team_test.go
  • internal/provider/goclaw/teams.go
  • internal/provider/goclaw/ws_test_helpers_test.go
  • internal/reconciler/compare.go
  • internal/reconciler/compare_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sync-drift-root

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vanducng vanducng merged commit a557634 into main May 30, 2026
6 checks passed
@vanducng vanducng deleted the fix/sync-drift-root branch May 30, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant