This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Fix uniqueness validation to correctly work with STI#64
Closed
rykov wants to merge 1 commit into
Closed
Conversation
|
@rykov Thanks for the fix. I've just run into this issue (and wrote some tests too). Is there anything I can do to help this pull request along? |
|
+1, I have just run into this bug as well. |
Contributor
|
I fixed that problem (a bit different) for the current master (1.3.0.beta) in #72 . After merging my pull request this pull request can AFAICS be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, uniqueness validation check is done by calling
resource.model.first, which only scopes the query to that particular class. This patch usesproperty.modelinstead to scope the query to the class in which the property was defined and its children.This is the best solution that I could find. There is no easy way to scope the query to the class which calls
validates_uniqueness_of, only the class that defines the property.