Fix off-by-one error in parse_range_str page range handling#107
Open
yijinlee wants to merge 1 commit into
Open
Fix off-by-one error in parse_range_str page range handling#107yijinlee wants to merge 1 commit into
parse_range_str page range handling#107yijinlee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_range_strreturns 1-based page numbers, butload_pdf_imagesiterates with a 0-based index. This causes--page-range 1to return page 2,--page-range 2to return page 3, etc.Fix in
chandra/input.py,parse_range_str.Steps to reproduce error:
chandra input.pdf ./output --page-range 1