Integrate JiT compilation into CLI runtime#2184
Closed
rafal-hawrylak wants to merge 3 commits into
Closed
Conversation
72e576f to
f9c7136
Compare
ikholopov-omni
requested changes
Jun 3, 2026
| } else { | ||
| callback(null, res.response); | ||
|
|
||
| // Guard against double-initialization in some environments (e.g. Bazel) |
Collaborator
There was a problem hiding this comment.
Can we please avoid these hacks and keep initialization idempotent, please?
Collaborator
Author
There was a problem hiding this comment.
Will address it here: #2211. Not addressed yet.
- Extract handleParamsOverloads to a standalone function outside Runner. - Add static factory methods Runner.create() and Runner.resume(). - Add overloaded constructor signatures to Runner to preserve backwards compatibility. - Ensure the options parsing uses spread defaults instead of conditional assignments. - Restructure cancel to accept typed CancelReason instead of raw strings. - Refactor the complex ternary SKIPPED tasks mapping into an explicit if/else block. - Extract task generation logic from compileJitAction to createTasksFromJitResponse. - Resolve worker script path in jit_loader.js using __dirname relative resolution. - Convert database request Uint8Array responses to arrays in compiler.ts before IPC transmission.
4ead263 to
fe57a91
Compare
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2110 - [Integrate JiT compilation into CLI]