Skip to content

Integrate JiT compilation into CLI runtime#2184

Closed
rafal-hawrylak wants to merge 3 commits into
mainfrom
pr4b-jit-runtime
Closed

Integrate JiT compilation into CLI runtime#2184
rafal-hawrylak wants to merge 3 commits into
mainfrom
pr4b-jit-runtime

Conversation

@rafal-hawrylak

@rafal-hawrylak rafal-hawrylak commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Part of #2110 - [Integrate JiT compilation into CLI]

@rafal-hawrylak rafal-hawrylak requested a review from a team as a code owner May 28, 2026 05:32
@rafal-hawrylak rafal-hawrylak requested review from krushangSk17 and removed request for a team May 28, 2026 05:32
@rafal-hawrylak rafal-hawrylak removed the request for review from krushangSk17 May 28, 2026 09:35
@rafal-hawrylak rafal-hawrylak force-pushed the pr4b-jit-runtime branch 3 times, most recently from 72e576f to f9c7136 Compare May 28, 2026 13:44
Comment thread cli/api/commands/run.ts Outdated
Comment thread cli/api/commands/run.ts Outdated
Comment thread cli/api/commands/run.ts
Comment thread cli/api/commands/run.ts Outdated
Comment thread cli/api/commands/run.ts
Comment thread cli/api/commands/run.ts Outdated
Comment thread cli/api/commands/run.ts
Comment thread cli/vm/jit_worker.ts
} else {
callback(null, res.response);

// Guard against double-initialization in some environments (e.g. Bazel)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please avoid these hacks and keep initialization idempotent, please?

@rafal-hawrylak rafal-hawrylak Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address it here: #2211. Not addressed yet.

Comment thread cli/index.ts
- Extract handleParamsOverloads to a standalone function outside Runner.
- Add static factory methods Runner.create() and Runner.resume().
- Add overloaded constructor signatures to Runner to preserve backwards compatibility.
- Ensure the options parsing uses spread defaults instead of conditional assignments.
- Restructure cancel to accept typed CancelReason instead of raw strings.
- Refactor the complex ternary SKIPPED tasks mapping into an explicit if/else block.
- Extract task generation logic from compileJitAction to createTasksFromJitResponse.
- Resolve worker script path in jit_loader.js using __dirname relative resolution.
- Convert database request Uint8Array responses to arrays in compiler.ts before IPC transmission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants