[DCP - BQ Federation] Propagate location in to the BQ connection#2022
Merged
Conversation
…her LOCATION or REGION flag because base DC one uses location, but DCP already uses REGIOn.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces location propagation for BigQuery operations by updating the BigQueryExecutor and AggregationRunner classes to accept and utilize a location parameter. Additionally, the CLI flags in main.py now support a fallback to the REGION environment variable if LOCATION is not provided. Review feedback suggests initializing the bigquery.Client with the location parameter directly to ensure consistency across all operations and to simplify subsequent query calls by removing redundant parameters.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using the env var REGION or LOCATION because base DC ingestion helper uses LOCATION, while DCP has been using the region env var everywhere. Would be great to align on one long term but this should be harmless.