Skip to content

Feature/channel mapping resolution dim#39

Open
tombonfert wants to merge 7 commits into
mainfrom
feature/channel_mapping_resolution_dim
Open

Feature/channel mapping resolution dim#39
tombonfert wants to merge 7 commits into
mainfrom
feature/channel_mapping_resolution_dim

Conversation

@tombonfert
Copy link
Copy Markdown
Collaborator

@tombonfert tombonfert commented May 29, 2026

Summary

Changes

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

@tombonfert tombonfert requested a review from a team as a code owner May 29, 2026 15:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.32%. Comparing base (76e566f) to head (e95ffeb).

Files with missing lines Patch % Lines
src/impulse_reporting/persist/report_storage.py 84.21% 2 Missing and 1 partial ⚠️
..._engine/analyze/metadata/time_series_expression.py 87.50% 1 Missing and 1 partial ⚠️
src/impulse_reporting/meta/container_dimensions.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   86.25%   86.32%   +0.06%     
==========================================
  Files          52       52              
  Lines        4168     4218      +50     
  Branches      500      506       +6     
==========================================
+ Hits         3595     3641      +46     
- Misses        477      479       +2     
- Partials       96       98       +2     
Files with missing lines Coverage Δ
...mpulse_query_engine/analyze/query/query_builder.py 87.77% <100.00%> (+0.27%) ⬆️
...ne/analyze/query/solvers/key_value_store_solver.py 92.92% <100.00%> (+0.16%) ⬆️
...query_engine/analyze/query/solvers/query_solver.py 85.71% <ø> (ø)
src/impulse_reporting/core/report.py 89.12% <100.00%> (+0.38%) ⬆️
src/impulse_reporting/meta/container_dimensions.py 97.05% <91.66%> (-2.95%) ⬇️
..._engine/analyze/metadata/time_series_expression.py 74.26% <87.50%> (+0.57%) ⬆️
src/impulse_reporting/persist/report_storage.py 84.56% <84.21%> (-0.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant