Add explicit check for name not None#9265
Open
maneesh29s wants to merge 1 commit into
Open
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ±0 31 suites ±0 11h 10m 2s ⏱️ - 7m 26s For more details on these failures, see this check. Results for commit ead8f87. ± Comparison against base commit cf508b9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesWith #9120 , I had added dask worker's name as a prefix into the default executor.
The
LocalClusterby default names the workers as numbers, starting from 0.Assuming the LocalCluster spawns 3 workers, 1 thread each, the names of the dask workers are allocated like this:
The prefix
0-is missing from the first worker's name.This PR fixes this, explictly checking for
name is not None.