DAOS-18866 vos: unconditional punch fix#18219
Conversation
|
Ticket title is 'ior/hard.py:IorHardBasic.test_ior_hard - ior No space left on device' |
Nasf-Fan
left a comment
There was a problem hiding this comment.
The patch is fine. But I cannot understand why the original logic will cause PMEM trouble.
There was a problem hiding this comment.
This patch looks ok-ish but:
- This very odd such a bug won't cause a lot more serious issues.
- It is a little frightening we do not have a unit test covering this scenario.
- This does not solve the DAOS-18866 issue but something interesting has happened. For the first time I see one of the test cases actually PASSed. Till now either all of them have failed or all of them have PASSed. I will re-test to confirm this effect.
Thanks @janekmi . I guess it could be related to the unconditional punch changes. I updated to PR to return -DER_NONEXIST before starting tx when possible (which mimics the original behavior), could retry and see if it could fully solve the issue? Thanks in advance. |
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18219/2/testReport/ |
|
Test stage Unit Test bdev completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18219/2/testReport/ |
|
Test stage Unit Test with memcheck completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18219/2/testReport/ |
Return DER_NONEXIST error when object doesn't exist for unconditional puch case. This patch also fixed vos_obj_incarnate() to return DER_NONEXIST error when CREATE flag isn't present. Signed-off-by: Niu Yawei <[email protected]>
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18219/3/testReport/ |
Cancel-prev-build: false Test-tag: test_ior_hard Skip-func-test-hw-large: false Skip-func-test-hw-large-md-on-ssd: true Allow-unstable-test: true
Return DER_NONEXIST error when object doesn't exist for unconditional
puch case. This patch also fixed vos_obj_incarnate() to return
DER_NONEXIST error when CREATE flag isn't present.
Steps for the author:
After all prior steps are complete: