docs(agents): WSL desktop builds target the Windows Electron app - #599
Merged
Conversation
On WSL machines "the desktop app" means the Windows app: build via npm run electron:build:win + the NSIS installer, never a Linux AppImage/deb under WSLg. WSL cannot compile node-pty for win32, so drive the build from WSL by rsyncing to a Windows-local dir and running Windows npm via cmd.exe. Generated with Amplifier Co-Authored-By: Amplifier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Doc-only, one-line edit to AGENTS.md: strengthens the Windows Electron build guidance in the Building section.
Why
On WSL machines, "the desktop app" means the Windows app. The previous line only said Windows desktop builds must run on native Windows; the new guidance makes the intent unambiguous:
npm run electron:build:win+ NSIS installer) — never a Linux AppImage/deb under WSLg.node-ptyfor win32, so the build must run as a native Windows process.cmd.exe(see docs/development/windows-electron-build.md).How to verify
Read the diff — single hunk in AGENTS.md, no code changes.
Breaking changes
None (documentation only).