feat(amplifier): resume with full conversation history by default - #598
Merged
Conversation
Every Freshell-managed Amplifier resume now launches `amplifier session resume --full-history <sessionId>` instead of `amplifier resume <sessionId>`, so resumed sessions show the full conversation history rather than Amplifier's truncated "…N earlier messages" tail. The `session resume` subcommand form is required because plain `amplifier resume` rejects `--full-history`. Changes: - extensions/amplifier/freshell.json: manifest resumeArgs - server/coding-cli/providers/amplifier.ts: getResumeArgs - crates/freshell-platform/src/cli_launch_goldens.rs: amplifier spec, goldens G-A2/G-A4b, and the manifest-parity golden - crates/freshell-freshagent/src/terminal_tabs.rs: recording spec and argv assertion (plus one comment) - JS test assertions updated: amplifier-provider unit test, amplifier-session-association, amplifier-stub-adoption-contract - e2e fixtures (fake-amplifier-cli.mjs, fake-amplifier-activity-cli.mjs) recognize the new argv shape (session id = last element) - e2e specs updated for the new amplifier argv (codex assertions untouched): amplifier-restore-rust, remote-tab-linkage-rust, mcp-qa-smoke-rust, sidebar-click-resume, terminal-activity-rust - Comment-only sweep of stale "amplifier resume <id>" wording in freshell-ws, freshell-sessions, freshell-server, freshell-terminal Compatibility: no version guard added — requires an Amplifier CLI that supports `session resume --full-history` (verified on v2026.08.01). Generated with Amplifier Co-Authored-By: Amplifier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Every Freshell-managed Amplifier resume now launches
amplifier session resume --full-history <sessionId>instead ofamplifier resume <sessionId>. Thesession resumesubcommand form is required because plainamplifier resumerejects--full-history.resumeArgsgetResumeArgsamplifier-provider.test.ts,amplifier-session-association.test.ts,amplifier-stub-adoption-contract.test.tsfake-amplifier-cli.mjs/fake-amplifier-activity-cli.mjsrecognize the new argv shape (session id = last element)amplifier-restore-rust,remote-tab-linkage-rust,mcp-qa-smoke-rust,sidebar-click-resume,terminal-activity-rust(codex assertions untouched)amplifier resume <id>wording:freshell-ws/src/terminal.rs,freshell-sessions/src/amplifier_stub.rs,freshell-server/src/existence_by_id.rs,freshell-terminal/src/registry.rs,freshell-ws/tests/amplifier_launcher_identity.rsWhy
Resumed Amplifier sessions previously showed Amplifier's truncated "…N earlier messages" tail. With
--full-history, resumed sessions show the full conversation history.How to verify
npm test): green — client 4793, server 4825, electron 350 passed. Two first-run flakes (monaco-mock render race, remote-proxy timeout race) passed in isolation and on rerun — pre-existing.cargo test --workspace: green — 100 suites, 0 failures.FRESHELL_RUN_REAL_PROVIDER_CONTRACTS=1), directly exercisingsession resume --full-history.--project=rust-chromium): all amplifier argv assertions green. 4 tests fail, but a baseline run at origin/main @ 2d4fefb shows the IDENTICAL 4 failures at identical lines — pre-existing main debt, not this branch:amplifier-restore-rustensure-after-GC expectation superseded by resume-validation AD-5 (PR Resume validation: disk-existence gate before resuming coding-CLI sessions #591)FRESHELL_CODEX_MANAGED_LAUNCHdefault-ON vs plain fake CLI fixturesCompatibility / breaking changes
No version guard added — requires an Amplifier CLI that supports
session resume --full-history(verified on v2026.08.01). Older Amplifier builds would fail resume; deemed acceptable, but flagging for reviewers in case you disagree.Suggested follow-ups (separate issues, not this PR)
amplifier-restore-rust.spec.tswith AD-5 resume-validation behaviorGenerated with Amplifier
Co-Authored-By: Amplifier [email protected]