feat(deck): rounded key tiles, larger icons, regular-weight titles with letter spacing - #585
Merged
Conversation
- Task 1: add ensureRoundRect guard at both real-ctx seams (roundRect is Baseline 2023; VirtualDeckPanel hands the renderer a real ctx in any browser, so an unguarded call could throw uncaught pre-Firefox 112 / Safari 16) and note letterSpacing needs no guard (inert expando) - Task 2: correct the empty-kind claim (kind 'empty' was never rendered in the test file; the frame test introduces the first render) - Task 3: drawRing has 8 call sites, not 7 - Record empirical Chromium verification of the trailing-inclusive letterSpacing measureText model and the classic-preview clip probe (no legible content loss) in new Load-Bearing Validation Notes
…acing across all three context impls
…lance in harness - Add ctx.restore() after switch closes in renderKey (src/deck/tile-renderer.ts) before getImageData return. This balances the ctx.save() called by beginKeyFrame. - Update recordingCtx test harness to track save/restore calls: * Count saves and restores in local counters * Expose getSaves() and getRestores() functions via return object * Pass counters through to renderTab helper - Update 'rounded key frame' test: * Extract getSaves/getRestores from test results * Assert saves === restores (balanced) for each key kind * Assert saves >= 1 (save/restore actually occurred) This prevents regressions where ctx.save/restore mismatch could silently break. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
…y frame 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
… RepoIcon 600 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
…itting 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
…s with its slot 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <[email protected]>
- Remove dead 'captured' variable assignment in the 'every key kind paints...' test (line 278-286) - Fix recordingCtx harness: clear both pendingArc and pendingRound after all operations (fill/clip/stroke) to prevent stale pending records from leaking into subsequent captures - Add length assertions before .every() calls in iconLayout test to guard against vacuous passes on empty arrays Generated with Amplifier Co-Authored-By: Amplifier <[email protected]>
pull Bot
pushed a commit
to HinchK/freshell
that referenced
this pull request
Jul 31, 2026
…erminal identity (danshapiro#584), deck visual tweaks (danshapiro#585) Conflict resolution (crates/freshell-freshagent/src/terminal_tabs.rs, settle_gated_create): kept BOTH sides, ordered spawn-gate acquire (D-C-R, ours) BEFORE the PIN2 claude prespawn durable binding (theirs) — a gate rejection must not leave a stale prespawn ledger row, so the durable write happens only after a permit is secured. Post-merge semantic fix: pinned FRESHELL_CODEX_MANAGED_LAUNCH=0 in rest_locator_identity.rs::rest_created_codex_pane_binds_identity_row_and_ledger (new in danshapiro#584, written pre-flip; exercises the plain-CLI codex path with a sleeper fake that cannot serve an app-server sidecar). Pre-merge analysis recorded no redundancy between the danshapiro#582 review-hardening (d9705fd) and the remote delta; danshapiro#586 touches resume-resolve-contract.ts, not session-contract.ts — CrashTrace work composes cleanly. Generated with Amplifier Co-Authored-By: Amplifier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual refinement of the Stream Deck key rendering (follow-up to #576/#580). Client-only, rendering-only — no changes to sorting, state classification, interaction, settings, or transports.
ensureRoundRectguard: browsers without canvas roundRect get square corners instead of a crash.Quality: TDD throughout; plan review passed round 1; independent delta review passed round 1 with zero blockers (reviewer re-derived all frame/ring/clip geometry); headless-Chromium probes verified letter-spacing measurement behavior and pixel-diffed the rounded clipping; 241 relevant tests + full check/lint/typecheck green. Minor deferred polish noted in review logs (1px content inset at the two largest key sizes).