Skip to content

Remove default value in for Type in ErrorModel#952

Open
hiddenmarten wants to merge 1 commit into
danielgtaylor:mainfrom
hiddenmarten:feature/remove-default-about-blank
Open

Remove default value in for Type in ErrorModel#952
hiddenmarten wants to merge 1 commit into
danielgtaylor:mainfrom
hiddenmarten:feature/remove-default-about-blank

Conversation

@hiddenmarten
Copy link
Copy Markdown
Contributor

@hiddenmarten hiddenmarten commented Feb 2, 2026

Hi,

I'm not sure if this "fix" is really necessary, but I faced an issue using huma with openapigenerator.

The thing is about:blank is not suitable for the most of uri validators (in my case one included in R client), so my solution was to remove it from the result openapi spec, probably it would be helpful to remove or update it here.

Thanks for your project, it's great!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.69%. Comparing base (2a548cc) to head (d3d61af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          23       23           
  Lines        4571     4571           
=======================================
  Hits         4237     4237           
  Misses        275      275           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented May 28, 2026

Hey @hiddenmarten! According to the RFC, this value should default to about:blank when no explicit value is given: https://www.rfc-editor.org/rfc/rfc9457.html#section-3.1.1

I don't have particularly strong feelings either way. It's a little odd that openapi-generator doesn't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants