Unified camera panel (no-reparent) — prototype#39
Closed
danielchalmers wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Closing — the unified-panel layout isn't the direction; keeping the dedicated bottom bar. Pursuing WPF-composited (D3DImage) video rendering instead to fix the underlying airspace issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype for evaluation (not ready to merge)
Reworks the video area into a single
CameraLayoutPanelholding all four players, so they're never reparented — switching views just re-arranges/resizes them in place, which eliminates the camera-switch flash.UpdateCameraHostLayout/MoveHostToSlot/etc.).Known gaps in this prototype
Verification
Build clean, 93 tests pass, smoke-launch clean. The layout itself needs your eyes.