Skip to content

Update AGENTS.md for view-model architecture#36

Merged
danielchalmers merged 1 commit into
mainfrom
claude/update-agents-guidance
Jun 18, 2026
Merged

Update AGENTS.md for view-model architecture#36
danielchalmers merged 1 commit into
mainfrom
claude/update-agents-guidance

Conversation

@danielchalmers

Copy link
Copy Markdown
Owner

What

Updates the agent guidance to match the architecture established in #34 and #35, so future agents extend the codebase the right way instead of re-growing a god-file.

Removed

  • "Preserve existing MVVM patterns … unless asked to refactor." — when the existing pattern was a 996-line Window that was also its own view-model, this line actively told agents to keep piling on. (The useful half — bindings/XAML style — is already covered under the XAML section.)

Added

  • Architecture section documenting the two projects: SentryReplay.Data (pure domain/playback logic, no WPF/Flyleaf — keep it that way) and the WPF app (views + view-models + services), plus the rule that view-models hold no control references.
  • Where new code goes section: new feature logic/state/commands go in a view-model, not window code-behind; don't default to the biggest existing file; keep code-behind small (flag *.xaml.cs over ~150 lines or holding non-view logic).
  • Testing guidance now asks for tests on new view-model/domain logic and notes view-models are directly constructible in tests (MainWindowViewModelTests).

Why

Docs-only. The earlier guidance was the main thing steering agents toward the god-file; the structural work in #34/#35 only sticks if the written guidance reinforces it.

Notes

Final step of the reorg plan. Deliberately still no DataDomain rename and no per-feature slice folders. The VideoPlayerController split (829 lines) remains a deferred, separate effort.

@danielchalmers danielchalmers merged commit 24d1fb7 into main Jun 18, 2026
1 check passed
@danielchalmers danielchalmers deleted the claude/update-agents-guidance branch June 18, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant