Fix Windows CI: add Mesa software OpenGL for headless napari tests - #181
Merged
Conversation
…GL support Co-authored-by: nfahlgren <[email protected]>
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Aug 13, 2026 1:15a.m. | Review ↗ | |
| Code coverage | Aug 13, 2026 1:22a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 100% |
| Python | 100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Copilot created this pull request from a session on behalf of
nfahlgren
August 13, 2026 01:16
View session
nfahlgren
marked this pull request as ready for review
August 13, 2026 01:19
nfahlgren
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build (3.13, windows-latest)deploy job fails because napari/vispy callsglGetIntegerv(GL_MAX_TEXTURE_SIZE)duringViewerinitialization, but GitHub Actions Windows runners have no GPU, so no OpenGL context exists and PyOpenGL raisesGL_INVALID_OPERATION(error 1282). The priorNAPARI_TESTING=1fix was insufficient — it sets napari's test mode but doesn't provide an OpenGL implementation.Changes
.github/workflows/deploy.yml: Addssciwr/setup-mesa-opengl@v1as a Windows-only step before tests run. This installs Mesa3D's CPU-basedopengl32.dllon the runner, giving napari/vispy a valid software OpenGL context to initialize against.