Skip to content

feat: let wasGeneratedBy in BareAsset and Dandiset to have range of Activity#417

Open
candleindark wants to merge 1 commit into
linkml-conversionfrom
linkml-conversion-handle-wasGeneratedBy-range-diff
Open

feat: let wasGeneratedBy in BareAsset and Dandiset to have range of Activity#417
candleindark wants to merge 1 commit into
linkml-conversionfrom
linkml-conversion-handle-wasGeneratedBy-range-diff

Conversation

@candleindark

Copy link
Copy Markdown
Member

This PR is a possible solution to #406

With schemaKey being the designator
type, instances of subclasses of
Activity should be able to validate
into the corresponding subclasses. Though
this solution would relex the schema a bit
for BareAsset and Dandiset

…e of `Activity`

With `schemaKey` being the designator
type, instances of subclasses of
`Activity` should be able to validate
into the corresponding subclasses. Though
this solution would relex the schema a bit
for `BareAsset` and `Dandiset`
@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.05%. Comparing base (43e4426) to head (d9cb728).

Additional details and impacted files
@@                Coverage Diff                 @@
##           linkml-conversion     #417   +/-   ##
==================================================
  Coverage              49.05%   49.05%           
==================================================
  Files                     20       20           
  Lines                   2436     2436           
==================================================
  Hits                    1195     1195           
  Misses                  1241     1241           
Flag Coverage Δ
unittests 49.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark

Copy link
Copy Markdown
Member Author

As pointed out by @yarikoptic, we should be able to override the range of Dandiset.wasGeneratedBy to Project in the LinkML schema without violating the monotonicity rule to be in alignment with the definition in the Pydantic model,

wasGeneratedBy: Optional[Sequence[Project]] = Field(
.

However, some tests against LinkML behavior should be added as well to check against regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant