Validate client buffer registration ownership#83
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: dallison <[email protected]>
Co-authored-by: dallison <[email protected]>
Co-authored-by: dallison <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
A client could send raw RegisterClientBuffer/UnregisterClientBuffer requests for another publisher's channel/session/buffer group. The server accepted those requests without tying them to the publisher that owns the buffer group, allowing fd-backed/split-buffer registrations to be overwritten or erased. On Android fd-backed buffers this could make subscribers map the wrong or missing backing fd, causing crashes or corrupted reads.
Root cause
Client-buffer registration metadata was keyed only by session and buffer index, and the register/unregister protocol carried no publisher ownership token. Server handlers validated the session/channel but not that the requesting connection owned the publisher or the existing buffer group.
Fix
Validation
$HOME/go/bin/bazelisk test //server:server_test$HOME/go/bin/bazelisk test //client:client_test //shadow:shadow_test$HOME/go/bin/bazelisk test //rust_client:client_test //rust_client:syscall_failure_test$HOME/go/bin/bazelisk test //...