release: merge dev into main (ERC-8153 exportSelectors + release-please)#31
Merged
Conversation
Every facet now implements ERC-8153's `exportSelectors() external pure`, reporting its own selectors on-chain. Selector discovery moves from the off-chain FFI helper (`forge inspect`) to this on-chain source of truth. - Add `IFacet` interface + `exportSelectors()` to all core facets and mocks (selectors referenced as `this.<fn>.selector`, self-excluded per ERC-8153) - Add `Selectors.decode` helper; delete FFI-based `GetSelectors.sol` - Rewire deploy script and tests to read selectors via `exportSelectors()` - Set `ffi = false`; drop `--ffi` from CONTRIBUTING - Add `ExportSelectorsTester` (exact-set, self-exclusion, decoder fuzz) - Document self-reported-selector trust caveat and the selector-drift discipline rule Out of scope (kept ERC-2535): upgradeDiamond, facet events/errors, loupe.
feat: adopt ERC-8153 exportSelectors for on-chain facet self-description
- Add release-please (googleapis/release-please-action@v5) on push to main; release-type `simple`, seeded at 0.1.4 via manifest, `bump-minor-pre-major` so pre-1.0 breaking changes stay in 0.x (no surprise 1.0.0) - Add release-please-config.json + .release-please-manifest.json - Bump actions/checkout v4 -> v7 (foundry-toolchain@v1 already latest major, 1.9.0)
…tion-bumps ci: add release-please workflow and bump action versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
devtomain. Merging this activates release-please onmain, which will then open av0.2.0release PR (thefeat:below drives the minor bump;ci:does not bump).Included (PRs #29, #30)
feat:ERC-8153exportSelectors— on-chain facet self-descriptionexportSelectors() external pure; selector discovery moved off FFI ontoSelectors.decodeGetSelectors.soldeleted,ffi = false; deploy script + tests rewiredIFacet,ExportSelectorsTester; stays ERC-2535 (noupgradeDiamond/event/error changes)ci:release automation + action bumpsgoogleapis/release-please-action@v5on push tomain(release-typesimple, seeded at0.1.4,bump-minor-pre-major)actions/checkoutv4 → v7After merge
v0.2.0release PR (changelog from thefeat:commit).v0.2.0+ creates the GitHub release.Pre-1.0, unaudited — not for production use until audited.