Skip to content

⚡ Bolt: Optimize lambda closures in beast_decoder hot path #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d3mocide wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Optimize lambda closures in beast_decoder hot path #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@

**Learning:** Repeated fallback cache lookups (`_lookup.get_stale(icao)`) within multiple exception handlers can cause significant performance overhead during errors or rate-limiting events.
**Action:** When a method performs fallback dictionary iteration on failures, centralize the exception block to eliminate repetitive fallback logic, and implement a dedicated batch fallback method (`get_stale_many`) on the cache abstraction to perform direct, optimized attribute lookups (`self._entries.get`) instead of repetitive method invocations.

## 2025-02-28 - Optimize lambda execution in hot paths

**Learning:** Frequent definitions of ad-hoc lambdas (closures) within high-throughput message loops (like ADSB message decoding) adds measurable overhead due to repeated function allocations and context capturing.
**Action:** Use wrapper functions that take `fn` and `*args` to pass to the target function directly instead of passing parameterless closures, avoiding inner function creation at runtime.
30 changes: 15 additions & 15 deletions poller/normalizers/beast_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,16 @@ def ingest_frame(self, message_bytes: bytes, *, mlat_ticks: int | None = None, s
signal_int = int(signal)
ac.signal_quality = signal_int if ac.signal_quality is None else max(ac.signal_quality, signal_int)

typecode = self._safe(lambda: pms.adsb.typecode(hex_msg))
typecode = self._safe(pms.adsb.typecode, hex_msg)
if df in (17, 18):
if typecode is None:
return None

if 1 <= typecode <= 4:
callsign = self._safe(lambda: pms.adsb.callsign(hex_msg))
callsign = self._safe(pms.adsb.callsign, hex_msg)
if isinstance(callsign, str):
ac.callsign = _normalize_callsign(callsign)
category = self._safe(lambda: pms.adsb.category(hex_msg))
category = self._safe(pms.adsb.category, hex_msg)
if category is not None:
ac.category = str(category)

Expand All @@ -176,13 +176,13 @@ def ingest_frame(self, message_bytes: bytes, *, mlat_ticks: int | None = None, s
if 9 <= typecode <= 22:
if typecode <= 18 or typecode >= 20:
ac.on_ground = False
alt = self._safe(lambda: pms.adsb.altitude(hex_msg))
alt = self._safe(pms.adsb.altitude, hex_msg)
if alt is not None:
ac.altitude = float(alt)
self._update_cpr(ac, hex_msg, now)

if typecode == 19:
vel = self._safe(lambda: pms.adsb.velocity(hex_msg))
vel = self._safe(pms.adsb.velocity, hex_msg)
if isinstance(vel, tuple) and len(vel) >= 3:
spd, trk, vr = vel[0], vel[1], vel[2]
if spd is not None:
Expand Down Expand Up @@ -262,7 +262,7 @@ def _update_cpr(self, ac: _AircraftState, hex_msg: str, now: float):
resolved_lat: float | None = None
resolved_lon: float | None = None

oe = self._safe(lambda: pms.adsb.oe_flag(hex_msg))
oe = self._safe(pms.adsb.oe_flag, hex_msg)
if oe == 0:
ac.even_msg = hex_msg
ac.even_ts = now
Expand All @@ -272,7 +272,7 @@ def _update_cpr(self, ac: _AircraftState, hex_msg: str, now: float):

# Tier 1: global CPR with even+odd pair.
if ac.even_msg and ac.odd_msg and ac.even_ts and ac.odd_ts and abs(ac.even_ts - ac.odd_ts) <= 10:
latlon = self._safe(lambda: pms.adsb.position(ac.even_msg, ac.odd_msg, ac.even_ts, ac.odd_ts))
latlon = self._safe(pms.adsb.position, ac.even_msg, ac.odd_msg, ac.even_ts, ac.odd_ts)
if isinstance(latlon, tuple) and len(latlon) == 2:
lat, lon = latlon
if lat is not None and lon is not None:
Expand All @@ -281,7 +281,7 @@ def _update_cpr(self, ac: _AircraftState, hex_msg: str, now: float):

# Tier 2: local CPR decode against aircraft last known position.
if resolved_lat is None and ac.lat is not None and ac.lon is not None:
latlon = self._safe(lambda: pms.adsb.position_with_ref(hex_msg, ac.lat, ac.lon))
latlon = self._safe(pms.adsb.position_with_ref, hex_msg, ac.lat, ac.lon)
if isinstance(latlon, tuple) and len(latlon) == 2:
lat, lon = latlon
if lat is not None and lon is not None:
Expand All @@ -290,7 +290,7 @@ def _update_cpr(self, ac: _AircraftState, hex_msg: str, now: float):

# Tier 3: local CPR decode against configured receiver reference.
if resolved_lat is None:
latlon = self._safe(lambda: pms.adsb.position_with_ref(hex_msg, settings.region_lat, settings.region_lon))
latlon = self._safe(pms.adsb.position_with_ref, hex_msg, settings.region_lat, settings.region_lon)
if isinstance(latlon, tuple) and len(latlon) == 2:
lat, lon = latlon
if lat is not None and lon is not None:
Expand Down Expand Up @@ -421,17 +421,17 @@ def _to_entity(self, ac: _AircraftState, now: float | None = None) -> dict | Non
}

def _decode_altitude_reply(self, hex_msg: str) -> float | None:
alt = self._safe(lambda: pms.altcode(hex_msg))
alt = self._safe(pms.altcode, hex_msg)
if alt is None:
alt = self._safe(lambda: pms.common.altcode(hex_msg))
alt = self._safe(pms.common.altcode, hex_msg)
if isinstance(alt, (int, float)):
return float(alt)
return None

def _decode_squawk_reply(self, hex_msg: str) -> str | None:
sq = self._safe(lambda: pms.idcode(hex_msg))
sq = self._safe(pms.idcode, hex_msg)
if sq is None:
sq = self._safe(lambda: pms.common.idcode(hex_msg))
sq = self._safe(pms.common.idcode, hex_msg)
if isinstance(sq, str) and sq.strip():
return sq.strip()
if isinstance(sq, (int, float)):
Expand Down Expand Up @@ -559,9 +559,9 @@ def _prune_stale(self, stale_seconds: int = 600):
self._aircraft.pop(icao, None)

@staticmethod
def _safe(fn):
def _safe(fn, *args):
try:
return fn()
return fn(*args)
except Exception:
return None

Expand Down
Loading