fix: Salvium sync (post-fork native libs + connect status visibility)#1405
Merged
julian-CStack merged 1 commit intoJun 12, 2026
Merged
Conversation
julian-CStack
requested changes
Jun 11, 2026
julian-CStack
left a comment
julian-CStack
left a comment
Collaborator
There was a problem hiding this comment.
The pubspec lockfile does not need to be updated. Please drop that commit and I'll merge the changes in the other commit
mmokhi
force-pushed
the
fix/salvium-sync-status
branch
from
3605843 to
20499f1
Compare
updateNode() had the ConnectedSyncStatus and FailedSyncStatus calls commented out, so a failed daemon connection only got logged and the wallet stayed stuck on "Connecting..." forever instead of showing "unable to sync". This uncomments them so connect success and failure are both reflected in the sync status, matching how lib_monero_wallet already behaves. Both status classes are defined in this same file so it compiles as is.
mmokhi
force-pushed
the
fix/salvium-sync-status
branch
from
20499f1 to
0cb6240
Compare
Contributor
Author
Done @julian-CStack :) |
julian-CStack
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Salvium wallets cannot sync, against the default node or a self-hosted one. The default node (salvium.stackwallet.com:19081) is healthy and answers get_info/get_height over SSL, so this is client side, not a server.
Root cause: the bundled native wallet lib is pre-fork. cs_salvium_flutter_libs is the package that actually does the chain sync, and the committed lockfile is still pinned at 2.0.1 (pre-fork bins) even though the pubspec template already requires ^3.0.1. Builds only end up on 3.0.1 because plain pub get re-resolves at build time, the committed lock never reflected the fix and nothing makes it explicit/reproducible.
No published release carries the new bins yet: latest release v2.4.4 (2026-02-11) predates the bins bump (2026-05-26), so shipped Salvium has the same problem.
What
Notes
The sync fix itself is the 3.0.1 bins. The status uncomment is for visibility, if it still fails on 3.0.1 the real error surfaces instead of a spinner. Confirmed the branch is +2 commits clean on top of staging.