feat(midi): addEndDelay=False to skip trailing rest on export (AI)#1896
Merged
Conversation
Member
|
Wonderful! If all AI-PRs are this good, I'll be so glad to get more. Thank you SAY-5 + agent! (Sai Asish) I'm going to merge, and then put something in AGENTS.md for future (and also README) -- music21 uses even minor versions for betas and odds for releases, so I should have set HEAD to 10.2.0b1 and these should be "New in v10.3: ..." as the next release version. I was going to push those changes to this PR, but they're too many and would be out of scope. But just in case the agent (or human) reads this and learns from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
addEndDelaykeyword (default True, preserving current behavior) threaded through the MIDI export functions so callers can skip the trailing rest produced bygetEndEvents(), mirroring the existingaddStartDelaykeyword. When set to False the trailingDeltaTimebeforeEND_OF_TRACKis zero. Requested by @mscuthbert in #1141 ("Yes, very welcome feature"); this PR is entirely AI written, disclosed per CONTRIBUTING.md and CLAUDE.md.Closes #1141