Skip to content

wcurl: strip URL fragment identifier from output filename #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergiodj merged 1 commit into from
May 1, 2026
Merged

wcurl: strip URL fragment identifier from output filename #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,5 +266,12 @@ testUrlDecodingNonLatinLanguages()
## - Options are the same for all URLs (except --next)
## - URLs beginning with '-' (with and without using '--')

testFragmentStripping()
{
url='example.com/document.pdf#page=5'
ret=$(${WCURL_CMD} "${url}" 2>&1 | tr '\n' ' ')
assertContains "Verify whether 'wcurl' correctly strips #fragments from filenames" "${ret}" '--output document.pdf '
}

# shellcheck disable=SC1091
. shunit2
2 changes: 1 addition & 1 deletion wcurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ percent_decode()
get_url_filename()
{
# Remove protocol and query string if present.
hostname_and_path="$(printf %s "${1}" | sed -e 's,^[^/]*//,,' -e 's,?.*$,,')"
hostname_and_path="$(printf %s "${1}" | sed -e 's,^[^/]*//,,' -e 's,[?#].*$,,')"
# If what remains contains a slash, there is a path; return it percent-decoded.
case "${hostname_and_path}" in
# sed to remove everything preceding the last '/', e.g.: "example/something" becomes "something"
Expand Down