Remove the strict option and update to cucumber-core >= v17#1893
Closed
brasmusson wants to merge 24 commits into
Closed
Remove the strict option and update to cucumber-core >= v17#1893brasmusson wants to merge 24 commits into
brasmusson wants to merge 24 commits into
Conversation
* Delete a portion of the RSpec double verification that is not auto enabled * Add in a bit of a split for some of the glue code
* Remove ruby 2.1 patch * Moved top level errors out of runtime to bespoke errors file * Re-order errors according to names * Re-order requires and pivot to more optimal require relatives * Tidy up of rubocop autogen file
* When strict is removed, test cases with pending and undefined steps will always be reported as failed by the junit formatter.
* When strict is removed from cucumber-ruby-core pending and undefined steps will fail the test run (the exit code will be non-zero). * Also Cucumber::Core::Test::Result::TYPES has been removed.
* When strict is removed from cucumber-ruby-core pending and undefined steps will fail the test run (the exit code will be non-zero).
brasmusson
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes strict from everywhere inside cucumber-ruby. It depends on cucucmber-ruby-core#330.
It does also adapt cucumber-ruby to other changes in cucumber-core v17.0.0, like cucumber-ruby-core#317.
Type of change
Please delete options that are not relevant.
work as expected)
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses