feat: improve kubelet address detection for ignoring probes#189
Merged
Conversation
ctrox
force-pushed
the
improve-probe-addr
branch
2 times, most recently
from
883dd34 to
64c5433
Compare
Trying to guess the kubelet IP address in eBPF by using the comm name has proven very unreliable in some scenarios. Plus it requires certain k8s distributions to specify the kubelet binary name in the first place. This commit introduces a new approach: The manager now has a livenessProbe defined which is used to get the kubelet address from an request that is known to be from kubelet. Once we have the address, it's set on the redirector which will take care of inserting it into the respective BPF maps. After the insert, the map is frozen which should also improve performance.
ctrox
force-pushed
the
improve-probe-addr
branch
from
64c5433 to
806fada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to guess the kubelet IP address in eBPF by using the comm name has proven very unreliable in some scenarios. Plus it requires certain k8s distributions to specify the kubelet binary name in the first place.
This commit introduces a new approach: The manager now has a livenessProbe defined which is used to get the kubelet address from an request that is known to be from kubelet. Once we have the address, it's set on the redirector which will take care of inserting it into the respective BPF maps. After the insert, the map is frozen which should also improve performance.