Skip to content

chore(otel): Ensure daemonset uses local policy #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsingleton-dev merged 1 commit into from
May 11, 2026
Merged

chore(otel): Ensure daemonset uses local policy #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/ctrlplane/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ dependencies:
version: 0.1.6
- name: otel
repository: file://charts/otel
version: 0.2.1
version: 0.2.2
- name: wandb-base
repository: https://charts.wandb.ai
version: 0.11.11
Expand All @@ -14,5 +14,5 @@ dependencies:
- name: wandb-base
repository: https://charts.wandb.ai
version: 0.11.11
digest: sha256:03b431cdd1b20c20d969b0eacb90e33dec92599d877dde63f801f2fa926b8d86
generated: "2026-05-04T13:22:49.464936-04:00"
digest: sha256:f1eac868446cb9d10c2be8327207e72acda8c5136350a5a4b271463b25cc348b
generated: "2026-05-08T15:38:09.858607-05:00"
2 changes: 1 addition & 1 deletion charts/ctrlplane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: ctrlplane
description: Ctrlplane Helm chart for Kubernetes
type: application
version: 1.1.2
version: 1.1.3
appVersion: 1.0.0

maintainers:
Expand Down
2 changes: 1 addition & 1 deletion charts/ctrlplane/charts/otel/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ name: otel
type: application
description: A Helm chart for Kubernetes

version: 0.2.1
version: 0.2.2
appVersion: "0.109.0"
3 changes: 3 additions & 0 deletions charts/ctrlplane/charts/otel/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if eq (default "DaemonSet" .Values.workload.kind) "DaemonSet" }}
internalTrafficPolicy: Local
{{- end }}
ports:
- port: 9109
protocol: TCP
Expand Down
31 changes: 31 additions & 0 deletions charts/ctrlplane/tests/otel_internal_traffic_policy_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
suite: otel service internalTrafficPolicy is set for DaemonSet only
templates:
- charts/otel/templates/service.yaml
release:
name: ctrlplane

tests:
- it: service has internalTrafficPolicy=Local in default (DaemonSet) mode
asserts:
- equal:
path: spec.internalTrafficPolicy
value: Local

- it: service has internalTrafficPolicy=Local when workload.kind is set explicitly to DaemonSet
set:
otel:
workload:
kind: DaemonSet
asserts:
- equal:
path: spec.internalTrafficPolicy
value: Local

- it: service does NOT set internalTrafficPolicy when workload.kind is Deployment
set:
otel:
workload:
kind: Deployment
asserts:
- notExists:
path: spec.internalTrafficPolicy
Loading