fix: add_components does not set component.parent#114
Conversation
Signed-off-by: Sai Asish Y <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR fixes a bug in ChangesParent assignment in batch component addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
add_component sets component.parent = self, but add_components leaves parent unset when storing each component, so components added in a batch report a null parent (#112). This sets parent on the batch path too, and adds a regression test covering it.
Summary by CodeRabbit
Bug Fixes
Tests