Skip to content

Add backend check to prevent state admin from granting compact permission#1638

Merged
jlkravitz merged 1 commit into
csg-org:mainfrom
InspiringApps:fix/permission-check
Jun 10, 2026
Merged

Add backend check to prevent state admin from granting compact permission#1638
jlkravitz merged 1 commit into
csg-org:mainfrom
InspiringApps:fix/permission-check

Conversation

@landonshumway-ia

@landonshumway-ia landonshumway-ia commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

When the readSSN permission was added during development, the check for how it is granted at the compact level was not included in the utility function which verifies the caller's permission scopes to ensure a state admin cannot add permissions at the compact level. The UI prevents this, but in theory a state admin could call the API directly outside of the app UI, so this adds that auth check to prevent that.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@landonshumway-ia, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 6 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e746496b-26e2-40db-a783-adc745095e3d

📥 Commits

Reviewing files that changed from the base of the PR and between 625029d and 9bdb5ab.

📒 Files selected for processing (4)
  • backend/compact-connect/lambdas/python/common/cc_common/utils.py
  • backend/compact-connect/lambdas/python/staff-users/tests/function/test_handlers/test_patch_user.py
  • backend/compact-connect/lambdas/python/staff-users/tests/function/test_handlers/test_post_user.py
  • backend/compact-connect/lambdas/python/staff-users/tests/unit/test_collect_changes.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jlkravitz jlkravitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @isabeleliassen This is good to merge. Once merged, I will do a prod deploy since this is a hotfix.

@jlkravitz jlkravitz merged commit 7f00884 into csg-org:main Jun 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants