compilation: normalize user-defined ABI types in crytic exports#800
Open
nisedo wants to merge 1 commit into
Open
compilation: normalize user-defined ABI types in crytic exports#800nisedo wants to merge 1 commit into
nisedo wants to merge 1 commit into
Conversation
Retry ABI parsing after canonicalizing enum/contract/interface aliases to ABI-compatible types, and add a regression test covering nested tuple and array cases. Co-authored-by: Cursor <[email protected]>
nisedo
requested review from
Xenomega,
anishnaik and
samalws-tob
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type(for example enum/contract/interface aliases) instead of canonical ABI types.ParseABIFromInterfaceto normalize ABItypefields usinginternalType(enum -> uint8,contract/interface -> address,struct -> tuple) while preserving array suffixes, then retry parsing.Why
Running
medusa fuzzagainst a harness can fail before the fuzzing starts withunable to parse ABI for contract 'CollateralFloorMath'. The exported ABI contained alias-liketypevalues (e.g.NftKind,IPositionManager) that the ABI parser rejects. This change makes Medusa resilient to that export shape without changing behavior for already-canonical ABIs.Test plan
go test -v ./compilation/types -run TestParseABIFromInterface_NormalizesUserDefinedTypesgo fmt ./...python3 scripts/check_docs.pygolangci-lint run --timeout 5m0sactionlint